Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers: update status patch logic #660

Merged
merged 1 commit into from
Mar 30, 2023
Merged

controllers: update status patch logic #660

merged 1 commit into from
Mar 30, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Mar 30, 2023

Hotfix to deal with the issue, as we will soon be moving to the patch logic used by already rewritten controllers. This is however a pain for many users, so worth solving now.

Fixes #571
Fixes #258

@hiddeco hiddeco added the bug Something isn't working label Mar 30, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco 🎖️

Hotfix to deal with the issue, as we will soon be moving to the patch
logic used by already rewritten controllers. This is however a pain for
many users, so worth solving now.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco merged commit 6f0fd5f into main Mar 30, 2023
@hiddeco hiddeco deleted the update-patch-logic branch March 30, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants